Remove PR creation instructions from kelos-self-update TaskSpawner#469
Merged
Remove PR creation instructions from kelos-self-update TaskSpawner#469
Conversation
Replace PR creation instructions with issue-only directives in the kelos-self-update TaskSpawner, matching the pattern established in the other non-worker TaskSpawners (kelos-fake-user, kelos-fake-strategist). Non-worker TaskSpawners should only create issues, not PRs, so that maintainers can provide feedback through a consistent workflow. Fixes #465 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gjkim42
approved these changes
Feb 27, 2026
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="self-development/kelos-self-update.yaml">
<violation number="1" location="self-development/kelos-self-update.yaml:72">
P2: The README still describes `kelos-self-update` as creating PRs (line 38: `→ PR or Issue`, line 211: "Creates a PR for code changes or an issue if discussion is needed"). Update both to reflect the new issue-only behavior, matching the pattern of other non-worker TaskSpawners.
(Based on your team's feedback about keeping documentation and config updated with changes.) [FEEDBACK_USED]</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| ``` | ||
| gh issue create --title "<title>" --body "<description>" --label generated-by-kelos --label kelos/needs-input | ||
| ``` | ||
| - Do NOT create PRs. Only create issues |
There was a problem hiding this comment.
P2: The README still describes kelos-self-update as creating PRs (line 38: → PR or Issue, line 211: "Creates a PR for code changes or an issue if discussion is needed"). Update both to reflect the new issue-only behavior, matching the pattern of other non-worker TaskSpawners.
(Based on your team's feedback about keeping documentation and config updated with changes.)
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At self-development/kelos-self-update.yaml, line 72:
<comment>The README still describes `kelos-self-update` as creating PRs (line 38: `→ PR or Issue`, line 211: "Creates a PR for code changes or an issue if discussion is needed"). Update both to reflect the new issue-only behavior, matching the pattern of other non-worker TaskSpawners.
(Based on your team's feedback about keeping documentation and config updated with changes.) </comment>
<file context>
@@ -65,17 +65,11 @@ spec:
```
gh issue create --title "<title>" --body "<description>" --label generated-by-kelos --label kelos/needs-input
```
+ - Do NOT create PRs. Only create issues
Constraints:
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kelos-self-updateTaskSpawner prompt templateWhy
Issue #441 established the policy that non-worker TaskSpawners should not create PRs. PR #445 implemented this for
kelos-fake-user,kelos-fake-strategist, andkelos-triage, but missedkelos-self-update. This PR completes that work.Test plan
Fixes #465
🤖 Generated with Claude Code
Summary by cubic
Removed PR creation instructions from the kelos-self-update TaskSpawner and replaced them with issue-only guidance, so it opens issues instead of PRs. Fixes #465 by aligning with the established policy for non-worker TaskSpawners.
Written for commit d083df4. Summary will update on new commits.